brandboat commented on code in PR #19880:
URL: https://github.com/apache/kafka/pull/19880#discussion_r2143204966
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -794,8 +797,11 @@ public Options setMemTableConfig(final MemTableConfig
config) {
return this;
}
+ @Deprecated(since = "4.2", forRemoval = true)
@Override
public Options setRateLimiter(final RateLimiter rateLimiter) {
+ log.warn("rate_limiter has been deprecated in RocksDB v7.6.0." +
+ " See https://github.com/facebook/rocksdb/pull/10378";);
Review Comment:
> Could you also verify if options were deprecated in the Java API and in
the C++ code. For the latter, I do not actually not know where to look. Maybe
in the release notes. I am asking this because it seems that RocksDB's Java API
contains options that were deprecated long ago in the C++ code. Maybe we can
deprecate those options in our wrapper.
I've checked
- https://github.com/facebook/rocksdb/blame/v10.1.3/options/db_options.cc
- https://github.com/facebook/rocksdb/blob/v10.1.3/options/cf_options.cc
and collected all options marked as `kdeprecated`. According to the
definitions in
https://github.com/facebook/rocksdb/blob/57a8e69d4e75c317f6ab02d6fc2fdd404b366794/include/rocksdb/utilities/options_type.h#L73-L77
```
kDeprecated, // The option is no longer used in rocksdb. The
RocksDB
// OptionsParser will still accept this option if it
// happen to exists in some Options file. However,
// the parser will not include it in serialization
// and verification processes.
```
Among both 2 options files, `rate_limiter` has been marked as deprecated
since v7.6.0 and does not have a alternative. Therefore, I'm adding
`@Deprecated` to this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
