brandboat commented on code in PR #19880:
URL: https://github.com/apache/kafka/pull/19880#discussion_r2124465505
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -574,17 +574,6 @@ public long compactionReadaheadSize() {
return dbOptions.compactionReadaheadSize();
}
- @Override
- public Options setRandomAccessMaxBufferSize(final long
randomAccessMaxBufferSize) {
- dbOptions.setRandomAccessMaxBufferSize(randomAccessMaxBufferSize);
- return this;
- }
-
- @Override
- public long randomAccessMaxBufferSize() {
- return dbOptions.randomAccessMaxBufferSize();
- }
-
Review Comment:
BTW `random_access_max_buffer_size` is a windows specific option, and have
no effect in linux, as mentioned in
https://github.com/facebook/rocksdb/commit/cdad04b0512ae2c7ee4d62961b71e5dd25955726.
> Remove double buffering on RandomRead on Windows.
With more logic appear in file reader/write Read no longer
obeys forwarding calls to Windows implementation.
Previously direct_io (unbuffered) was only available on Windows
but now is supported as generic.
We remove intermediate buffering on Windows.
Remove random_access_max_buffer_size option which was windows specific.
Non-zero values for that opton introduced unnecessary lock contention.
Remove Env::EnableReadAhead(), Env::ShouldForwardRawRequest() that are
no longer necessary.
Add aligned buffer reads for cases when requested reads exceed read ahead
size.
This option no long take effect since rocksdb 5.4, I'll mark both method
`setRandomAccessMaxBufferSize` and `randomAccessMaxBufferSize` deprecated and
add warning message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
