lucasbru commented on code in PR #20714:
URL: https://github.com/apache/kafka/pull/20714#discussion_r2437177165
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##########
@@ -111,14 +113,16 @@ static String[] documentValidValues() {
* for consumer groups.
* @param isTransactional Whether the offset commit is
transactional or not.
* @param apiVersion The api version.
+ * @param topicIdPartitions Supplier for a list of topic-partition
pairs being committed.
+ * Topic ids may be ZERO_UUID if the
request does not support them.
*/
void validateOffsetCommit(
String memberId,
String groupInstanceId,
int generationIdOrMemberEpoch,
boolean isTransactional,
- int apiVersion
-
+ int apiVersion,
+ Supplier<List<TopicIdPartition>> topicIdPartitions
Review Comment:
Can you have another look? I implemented inline validation. The downside is,
that for every partition, we will have fetched the member identified by
`memberId` from the group.
I added a `partitionValidationRequired` boolean to shortcut partition-level
validation if we do not need it (in particular, if member epochs match).
I think the Group interface looks nicer, and there are no allocations, which
is nice. Maybe the logic is a bit more complex now.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
