dajac commented on code in PR #20714:
URL: https://github.com/apache/kafka/pull/20714#discussion_r2436476227
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##########
@@ -111,14 +113,16 @@ static String[] documentValidValues() {
* for consumer groups.
* @param isTransactional Whether the offset commit is
transactional or not.
* @param apiVersion The api version.
+ * @param topicIdPartitions Supplier for a list of topic-partition
pairs being committed.
+ * Topic ids may be ZERO_UUID if the
request does not support them.
*/
void validateOffsetCommit(
String memberId,
String groupInstanceId,
int generationIdOrMemberEpoch,
boolean isTransactional,
- int apiVersion
-
+ int apiVersion,
+ Supplier<List<TopicIdPartition>> topicIdPartitions
Review Comment:
I wonder whether this is the right way to do it because it forces us to
iterate on the topic-partition twice, once in validateOffsetCommit and once
later on when we construct the records. Have you considered inlining the check
in the later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
