lucasbru commented on code in PR #20714:
URL: https://github.com/apache/kafka/pull/20714#discussion_r2440005321
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -677,7 +670,20 @@ public CoordinatorResult<TxnOffsetCommitResponseData,
CoordinatorRecord> commitT
AuthorizableRequestContext context,
TxnOffsetCommitRequestData request
) throws ApiException {
- validateTransactionalOffsetCommit(context, request);
+ Group group = getGroupForTransactionalOffsetCommit(request);
Review Comment:
Yes, I considered this. It seemed we do not want to move the re-scheduling
of the heartbeat into the validation method - seemed like this was
intentionally kept outside. And then I kept the "getGroup" for non-txn case
symmetric for consistency. But if we are fine with moving the heartbeat inside,
let's do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
