lucasbru commented on code in PR #20714:
URL: https://github.com/apache/kafka/pull/20714#discussion_r2439047501
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -632,6 +618,17 @@ public CoordinatorResult<OffsetCommitResponseData,
CoordinatorRecord> commitOffs
.setPartitionIndex(partition.partitionIndex())
.setErrorCode(Errors.OFFSET_METADATA_TOO_LARGE.code()));
} else {
+ // Validate per-partition commit if needed
+ if (requiresPartitionValidation) {
+ group.validateOffsetCommitForPartition(
+ request.memberId(),
+ request.generationIdOrMemberEpoch(),
+ topic.name(),
+ topic.topicId(),
+ partition.partitionIndex()
+ );
Review Comment:
I had considered introducing a super-class of ModernGroupMember and
StreamsGroupMember and return the member. But indeed your approach seems
cleaner and easier to implement. I will revise the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
