lucasbru commented on code in PR #20714:
URL: https://github.com/apache/kafka/pull/20714#discussion_r2439722651
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -632,6 +618,17 @@ public CoordinatorResult<OffsetCommitResponseData,
CoordinatorRecord> commitOffs
.setPartitionIndex(partition.partitionIndex())
.setErrorCode(Errors.OFFSET_METADATA_TOO_LARGE.code()));
} else {
+ // Validate per-partition commit if needed
+ if (requiresPartitionValidation) {
+ group.validateOffsetCommitForPartition(
+ request.memberId(),
+ request.generationIdOrMemberEpoch(),
+ topic.name(),
+ topic.topicId(),
+ partition.partitionIndex()
+ );
Review Comment:
I have updated the code with this suggestion. It's a good idea. I don't see
anything wrong with it. Can you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
