m1a2st commented on code in PR #22977: URL: https://github.com/apache/kafka/pull/22977#discussion_r3675839819
########## docs/getting-started/upgrade.md: ########## @@ -46,6 +46,8 @@ type: docs * The broker-side OAUTHBEARER JWT validator now fails fast at startup when a JWKS endpoint (`sasl.oauthbearer.jwks.endpoint.url`) is configured but `sasl.oauthbearer.expected.audience` or `sasl.oauthbearer.expected.issuer` is not set. Brokers that previously started without these settings will now fail to start until they are configured. To intentionally accept tokens regardless of their audience or issuer, set the new `sasl.oauthbearer.allow.unverified.audience` or `sasl.oauthbearer.allow.unverified.issuer` configs (both default `false`) to `true`. * When clients connect to the cluster, they now include cluster and node information to enable detection and handling of misrouted connections. For further details, please refer to [KIP-1242](https://cwiki.apache.org/confluence/x/W4LMFw). * The `kafka-cluster.sh` tool now provides an `api-versions` command to display the API versions supported by the brokers or controllers, and it accepts both `--bootstrap-server` and `--bootstrap-controller`. As a result, `kafka-broker-api-versions.sh` is deprecated and will be removed in the next major release; use `kafka-cluster.sh api-versions` instead. For further details, please refer to [KIP-1220](https://cwiki.apache.org/confluence/x/-QkbFw). + * The `broker.id` configuration is deprecated and will be removed in Kafka 5.0. Please use `node.id` instead. For further details, please refer to [KIP-1232](https://cwiki.apache.org/confluence/x/Hgp3Fw). + * Tiered storage plugins are now configured with `node.id` in addition to `broker.id`. Since `broker.id` will no longer be passed to `RemoteStorageManager` and `RemoteLogMetadataManager` implementations in Kafka 5.0, plugins should read `node.id` instead. For further details, please refer to [KIP-1232](https://cwiki.apache.org/confluence/x/Hgp3Fw). Review Comment: Could you also update the KIP to reflect this change? ########## storage/src/testFixtures/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java: ########## @@ -133,9 +133,17 @@ public final class LocalTieredStorage implements RemoteStorageManager { /** * The ID of the broker which owns this instance of {@link LocalTieredStorage}. + * + * @deprecated Use {@link #NODE_ID} instead. This key is no longer passed to plugins from Kafka 5.0 (KIP-1232). */ + @Deprecated(since = "4.4", forRemoval = true) Review Comment: Could you explain why the test file needs `@Deprecated`? ########## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java: ########## @@ -81,7 +81,12 @@ public final class TopicBasedRemoteLogMetadataManagerConfig { public static final String REMOTE_LOG_METADATA_PRODUCER_PREFIX = "remote.log.metadata.producer."; public static final String REMOTE_LOG_METADATA_CONSUMER_PREFIX = "remote.log.metadata.consumer."; public static final String REMOTE_LOG_METADATA_ADMIN_PREFIX = "remote.log.metadata.admin."; + /** + * @deprecated Use {@link #NODE_ID} instead. This key is no longer passed to plugins from Kafka 5.0 (KIP-1232). + */ + @Deprecated(since = "4.4", forRemoval = true) public static final String BROKER_ID = "broker.id"; + public static final String NODE_ID = "node.id"; Review Comment: Could you also update the KIP to reflect this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
