chia7712 commented on code in PR #22977:
URL: https://github.com/apache/kafka/pull/22977#discussion_r3691712047
##########
storage/src/testFixtures/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java:
##########
@@ -233,14 +252,15 @@ public void configure(Map<String, ?> configs) {
final String shouldDeleteOnClose = (String)
configs.get(DELETE_ON_CLOSE_CONFIG);
final String transfererClass = (String)
configs.get(TRANSFERER_CLASS_CONFIG);
final String isDeleteEnabled = (String)
configs.get(ENABLE_DELETE_API_CONFIG);
- final Integer brokerIdInt = (Integer) configs.get(BROKER_ID);
+ final Integer nodeIdInt = nodeId(configs);
- if (brokerIdInt == null) {
- throw new InvalidConfigurationException(
- "Broker ID is required to configure the LocalTieredStorage
manager.");
+ if (nodeIdInt == null) {
+ throw new InvalidConfigurationException(format(
Review Comment:
This check could be moved to `nodeId`, and then `nodeId` could return `int`
type instead of `Integer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
