mingyen066 commented on code in PR #22977:
URL: https://github.com/apache/kafka/pull/22977#discussion_r3676778433
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -81,7 +81,12 @@ public final class TopicBasedRemoteLogMetadataManagerConfig {
public static final String REMOTE_LOG_METADATA_PRODUCER_PREFIX =
"remote.log.metadata.producer.";
public static final String REMOTE_LOG_METADATA_CONSUMER_PREFIX =
"remote.log.metadata.consumer.";
public static final String REMOTE_LOG_METADATA_ADMIN_PREFIX =
"remote.log.metadata.admin.";
+ /**
+ * @deprecated Use {@link #NODE_ID} instead. This key is no longer passed
to plugins from Kafka 5.0 (KIP-1232).
+ */
+ @Deprecated(since = "4.4", forRemoval = true)
public static final String BROKER_ID = "broker.id";
+ public static final String NODE_ID = "node.id";
Review Comment:
Covered by the KIP update as well —
TopicBasedRemoteLogMetadataManagerConfig.BROKER_ID is deprecated in 4.4 and
removed in 5.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
