mingyen066 commented on code in PR #22977:
URL: https://github.com/apache/kafka/pull/22977#discussion_r3690190281
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -138,7 +143,7 @@ public TopicBasedRemoteLogMetadataManagerConfig(Map<String,
?> props) {
consumeWaitMs = (long)
parsedConfigs.get(REMOTE_LOG_METADATA_CONSUME_WAIT_MS_PROP);
initializationRetryIntervalMs = (long)
parsedConfigs.get(REMOTE_LOG_METADATA_INITIALIZATION_RETRY_INTERVAL_MS_PROP);
initializationRetryMaxTimeoutMs = (long)
parsedConfigs.get(REMOTE_LOG_METADATA_INITIALIZATION_RETRY_MAX_TIMEOUT_MS_PROP);
- clientIdPrefix = REMOTE_LOG_METADATA_CLIENT_PREFIX + "_" +
props.get(BROKER_ID);
+ clientIdPrefix = REMOTE_LOG_METADATA_CLIENT_PREFIX + "_" +
props.get(NODE_ID);
Review Comment:
Done, with `ConfigException`. I left out the `else if
(props.containsKey(BROKER_ID))` branch — `RemoteLogManager` passes both keys
unconditionally, so it would warn on every startup about a key the operator
didn't set.
##########
storage/src/testFixtures/java/org/apache/kafka/server/log/remote/storage/LocalTieredStorage.java:
##########
@@ -233,14 +233,14 @@ public void configure(Map<String, ?> configs) {
final String shouldDeleteOnClose = (String)
configs.get(DELETE_ON_CLOSE_CONFIG);
final String transfererClass = (String)
configs.get(TRANSFERER_CLASS_CONFIG);
final String isDeleteEnabled = (String)
configs.get(ENABLE_DELETE_API_CONFIG);
- final Integer brokerIdInt = (Integer) configs.get(BROKER_ID);
+ final Integer nodeIdInt = (Integer) configs.get(NODE_ID);
Review Comment:
Done here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
