chia7712 commented on code in PR #22977:
URL: https://github.com/apache/kafka/pull/22977#discussion_r3688572242
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -138,7 +143,7 @@ public TopicBasedRemoteLogMetadataManagerConfig(Map<String,
?> props) {
consumeWaitMs = (long)
parsedConfigs.get(REMOTE_LOG_METADATA_CONSUME_WAIT_MS_PROP);
initializationRetryIntervalMs = (long)
parsedConfigs.get(REMOTE_LOG_METADATA_INITIALIZATION_RETRY_INTERVAL_MS_PROP);
initializationRetryMaxTimeoutMs = (long)
parsedConfigs.get(REMOTE_LOG_METADATA_INITIALIZATION_RETRY_MAX_TIMEOUT_MS_PROP);
- clientIdPrefix = REMOTE_LOG_METADATA_CLIENT_PREFIX + "_" +
props.get(BROKER_ID);
+ clientIdPrefix = REMOTE_LOG_METADATA_CLIENT_PREFIX + "_" +
props.get(NODE_ID);
Review Comment:
why don't we handle the deprecation?
```java
Object nodeIdObj = props.get(NODE_ID);
if (nodeIdObj == null) {
nodeIdObj = props.get(BROKER_ID);
if (nodeIdObj == null) {
throw new ConfigException("Both '" + NODE_ID + "' and '" + BROKER_ID
+ "' are missing. Please configure '" + NODE_ID + "'.");
}
LOG.warn("The '{}' configuration in remote log metadata manager is
deprecated and will be removed in Kafka 5.0. " +
"Please use '{}' instead.", BROKER_ID, NODE_ID);
} else if (props.containsKey(BROKER_ID)) {
LOG.warn("The '{}' configuration is deprecated and will be ignored in
Kafka 5.0. " +
"Please use '{}' instead.", BROKER_ID, NODE_ID);
}
clientIdPrefix = REMOTE_LOG_METADATA_CLIENT_PREFIX + "_" + nodeIdObj;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
