Nikita-Shupletsov commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3730701528
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -167,19 +169,28 @@ public void run() {
while (isRunning.get()) {
runOnce();
}
- } catch (final RuntimeException anyOtherException) {
- handleRuntimeException(anyOtherException);
+ } catch (final Throwable anyOtherThrowable) {
+ handleFatalThrowable(anyOtherThrowable);
} finally {
- clearInputQueue();
- clearUpdatingAndPausedTasks();
+ failRemainingTasks();
+ failPendingActions();
Review Comment:
yes, it's in case we are waiting for removal, for example. once we fail the
task, the thread is unblocked. so we want to do that after failing everything
else and marking the state updater as stopped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
