Nikita-Shupletsov commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3730768359
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -580,9 +620,6 @@ private void removeTask(final TaskId taskId,
} catch (final StreamsException streamsException) {
handleStreamsExceptionWithTask(streamsException, taskId);
future.completeExceptionally(streamsException);
- } catch (final RuntimeException runtimeException) {
Review Comment:
because we don't stop the thread on StreamsException, but we do on
RuntimeException. so in order to unify the shutdown and cleanup logic, I remove
that catch block. so now the exception will be caught in the run method. it
allows us to have the cleanup logic in one place instead of two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
