Nikita-Shupletsov commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3730775805
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -167,19 +169,28 @@ public void run() {
while (isRunning.get()) {
runOnce();
}
- } catch (final RuntimeException anyOtherException) {
- handleRuntimeException(anyOtherException);
+ } catch (final Throwable anyOtherThrowable) {
+ handleFatalThrowable(anyOtherThrowable);
Review Comment:
there is no reason to rethrow the exception here, as we are in the run
method. as it's in a separate method, it would be just swallowed and not shown
anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
