Nikita-Shupletsov commented on code in PR #23093:
URL: https://github.com/apache/kafka/pull/23093#discussion_r3730759930
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -862,6 +858,7 @@ public boolean checkStateUpdater(final long now,
if (stateUpdater.hasExceptionsAndFailedTasks()) {
handleExceptionsFromStateUpdater();
}
+ maybeThrowFatalExceptionFromStateUpdater();
Review Comment:
it goes after handleExceptionsFromStateUpdater, because it calls
drainExceptionsAndFailedTasks and processes them(adds them to the failed
tasks). so we first let that logic do its thing, then we check if we need to
fail the thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
