gabriellefu commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3868427354
##########
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##########
@@ -201,6 +208,28 @@ class ConfigAdminManager(nodeId: Int,
}
}
+ /**
+ * Perform the full GROUP config validation on the forwarding broker, before
the change is
+ * sent to the controller. See
[[kafka.server.ControllerConfigurationValidator]] for why the
+ * controller also performs this validation while a cluster may still
contain brokers that
+ * predate this broker-side check.
+ */
+ private def validateGroupConfigChangeOnBroker(resource:
IAlterConfigsResource): Unit = {
+ val configResource = new ConfigResource(GROUP, resource.resourceName())
Review Comment:
I have updated it, thanks for pointing it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
