gabriellefu commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3868431612
##########
core/src/test/scala/unit/kafka/server/ControllerConfigurationValidatorTest.scala:
##########
@@ -36,26 +37,30 @@ class ControllerConfigurationValidatorTest {
val config = new KafkaConfig(TestUtils.createDummyBrokerConfig())
val validator = new ControllerConfigurationValidator(config)
+ // The metadata.version in effect prior to this feature shipping
(KAFKA-20790), used for all
+ // tests that are not specifically about the upgrade-safety gate below.
+ val preGroupBrokerValidationMv: MetadataVersion =
MetadataVersion.LATEST_PRODUCTION
Review Comment:
have updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
