squah-confluent commented on code in PR #23896:
URL: https://github.com/apache/kafka/pull/23896#discussion_r4359951467


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/GroupSpecBuilder.java:
##########
@@ -242,22 +269,14 @@ public GroupSpec build() {
             ))
         );
 
-        Optional<Map<Uuid, Set<Integer>>> topicAssignablePartitionsMap = 
this.topicAssignablePartitionsMap;
         if (assignorOffload) {

Review Comment:
   We can remove it. I would keep the tests for group spec immutability since 
we really want that to not break for async assignors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to