squah-confluent commented on code in PR #23896:
URL: https://github.com/apache/kafka/pull/23896#discussion_r4379042500
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/GroupSpecImpl.java:
##########
@@ -51,43 +50,26 @@ private record AssignedPartitions(BitSet partitions, int
partitionCount) { }
/**
* Member subscription metadata keyed by member Id.
*/
- private final Map<String, MemberSubscriptionAndAssignmentImpl> members;
+ protected final Map<String, MemberSubscriptionAndAssignmentImpl> members;
/**
* The subscription type of the group.
*/
- private final SubscriptionType subscriptionType;
+ protected final SubscriptionType subscriptionType;
/**
* The partitions which are currently assigned to a member,
* keyed by topic id.
*/
private Map<Uuid, AssignedPartitions> assignedTopicPartitions;
Review Comment:
Hm, `ShareGroupSpecImpl.isPartitionAssigned` still needs an implementation
and the natural way to do it is the same as for consumer groups. Unless we
decide to throw a `NotSupportedException` in `isPartitionAssigned`?
I'm not opposed to defining a `ConsumerGroupSpecImpl` and common
`GroupSpecImpl` base class to keep things organized. It's just that I can't see
`ConsumerGroupSpecImpl` holding any extra logic right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
