dajac commented on code in PR #23896:
URL: https://github.com/apache/kafka/pull/23896#discussion_r4366848886
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/GroupSpecImpl.java:
##########
@@ -51,43 +50,26 @@ private record AssignedPartitions(BitSet partitions, int
partitionCount) { }
/**
* Member subscription metadata keyed by member Id.
*/
- private final Map<String, MemberSubscriptionAndAssignmentImpl> members;
+ protected final Map<String, MemberSubscriptionAndAssignmentImpl> members;
/**
* The subscription type of the group.
*/
- private final SubscriptionType subscriptionType;
+ protected final SubscriptionType subscriptionType;
/**
* The partitions which are currently assigned to a member,
* keyed by topic id.
*/
private Map<Uuid, AssignedPartitions> assignedTopicPartitions;
Review Comment:
Seing this, I wonder if we should have ConsumerGroupSpecImpl and move it
into it. If we don't want to have topicPartitionAllowedMap in the GroupSpec, it
would make sense to remove assignedTopicPartitions too. Have you considered it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
