dajac commented on code in PR #23896:
URL: https://github.com/apache/kafka/pull/23896#discussion_r4422226992
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/GroupSpecImpl.java:
##########
@@ -28,13 +28,12 @@
import java.util.HashMap;
import java.util.Map;
import java.util.Objects;
-import java.util.Optional;
import java.util.Set;
/**
* The assignment specification for a modern group.
*/
-public class GroupSpecImpl implements GroupSpec {
+public abstract class GroupSpecImpl implements GroupSpec {
Review Comment:
If we keep this file alone (see my previous comment), we should name it
`AbstractGroupSpec` or something like this. It is not an full implementation
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
