ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r504108760
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##########
@@ -483,7 +485,7 @@ public void testEagerSubscription() {
Collections.sort(subscription.topics());
assertEquals(asList("topic1", "topic2"), subscription.topics());
- final SubscriptionInfo info = getInfo(UUID_1, prevTasks, standbyTasks);
Review comment:
Oh right duh I was thinking it was just a single bit but it's a byte. In
that case we should have a test that verifies it goes from `0` to `1` to `2`,
etc -- might be good to verify the behavior on overflow as well, if you call
`subscriptionUserData` the max_value number of times
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
