ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r504110656
##########
File path:
streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java
##########
@@ -158,7 +159,8 @@ public ByteBuffer subscriptionUserData(final Set<String>
topics) {
LATEST_SUPPORTED_VERSION + 1,
taskManager.processId(),
userEndPoint(),
- taskManager.getTaskOffsetSums()
+ taskManager.getTaskOffsetSums(),
+ Bytes.EMPTY
Review comment:
We should do the same thing that we do in StreamsPartitionAssignor here,
ie a changing byte. This is supposed to be like the same exact thing but for a
"future version" of the partition assignor, to test version probing and general
compatibility.
It's a bit annoying that you have to just copy the same exact stuff but
that's just how it is for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
