[GitHub] [kafka] chia7712 commented on a change in pull request #9856: KAFKA-12171 Migrate streams:test-utils module to JUnit 5

[GitBox]

chia7712 commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555184290



##########
File path: 
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -448,29 +441,37 @@ private Topology setupTopologyWithInternalTopic(final 
String firstTableName,
         return builder.build(config);
     }
 
-    @Test
-    public void shouldNotRequireParameters() {
+    @ParameterizedTest(name = "{displayName} - {arguments}")

Review comment:
       ```@ParameterizedTest```
   ```
   TopologyTestDriverTest > [1] ENABLED PASSED
   
   TopologyTestDriverTest > [2] DISABLED PASSED
   
   TopologyTestDriverTest > [1] ENABLED PASSED
   
   TopologyTestDriverTest > [2] DISABLED PASSED
   ```
   
   ```@ParameterizedTest(name = "{displayName} - {arguments}")```
   ```
   TopologyTestDriverTest > shouldCloseProcessor(EosMode) - ENABLED PASSED
   
   TopologyTestDriverTest > shouldCloseProcessor(EosMode) - DISABLED PASSED
   
   TopologyTestDriverTest > shouldFeedStoreFromGlobalKTable(EosMode) - ENABLED 
PASSED
   
   TopologyTestDriverTest > shouldFeedStoreFromGlobalKTable(EosMode) - DISABLED 
PASSED
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org