ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555186158
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -448,29 +441,37 @@ private Topology setupTopologyWithInternalTopic(final
String firstTableName,
return builder.build(config);
}
- @Test
- public void shouldNotRequireParameters() {
+ @ParameterizedTest(name = "{displayName} - {arguments}")
Review comment:
Seems like we should maybe name the enum values: `EOS_ENABLED` and
`EOS_DISABLED`, then the output will be good automatically. What do you think?
Btw, I am being a nitpicky here because once we have a good pattern, we can
apply it in other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
