chia7712 commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555950498



##########
File path: 
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -448,29 +441,37 @@ private Topology setupTopologyWithInternalTopic(final 
String firstTableName,
         return builder.build(config);
     }
 
-    @Test
-    public void shouldNotRequireParameters() {
+    @ParameterizedTest(name = "{displayName} - {arguments}")

Review comment:
       The output of ```@ParameterizedTest``` is not readable to me so I prefer 
```@ParameterizedTest(name = "{displayName} - {arguments}")```. 
   ```
   TopologyTestDriverTest > [1] EOS_ENABLED PASSED
   
   TopologyTestDriverTest > [2] EOS_DISABLED PASSED
   
   TopologyTestDriverTest > [1] EOS_ENABLED PASSED
   
   TopologyTestDriverTest > [2] EOS_DISABLED PASSED
   
   TopologyTestDriverTest > [1] EOS_ENABLED PASSED
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to