ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r555981713



##########
File path: 
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -448,29 +441,37 @@ private Topology setupTopologyWithInternalTopic(final 
String firstTableName,
         return builder.build(config);
     }
 
-    @Test
-    public void shouldNotRequireParameters() {
+    @ParameterizedTest(name = "{displayName} - {arguments}")

Review comment:
       I looked into the reasoning for this choice and it's explained here:
   
   https://github.com/junit-team/junit5/issues/1496#issuecomment-404178095
   
   Seems like we are working around the intended design. It would be better to 
adjust the Gradle config to output the test display name too. (not sure if it's 
supported atm)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to