[GitHub] [kafka] ijuma commented on a change in pull request #9856: KAFKA-12171 Migrate streams:test-utils module to JUnit 5

Tue, 12 Jan 2021 13:02:38 -0800 


ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r556092222



##########
File path: 
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -448,29 +441,37 @@ private Topology setupTopologyWithInternalTopic(final 
String firstTableName,
         return builder.build(config);
     }
 
-    @Test
-    public void shouldNotRequireParameters() {
+    @ParameterizedTest(name = "{displayName} - {arguments}")

Review comment:
       It looks like a bug to me, personally. Check the Gradle test output html:
   
   ![Screenshot from 2021-01-12 
13-00-01](https://user-images.githubusercontent.com/24747/104374109-3abafe80-54d6-11eb-9253-38199aa1ea1c.png)
   
   IMO, the text output should output the method name too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to