chia7712 commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r556076389
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -448,29 +441,37 @@ private Topology setupTopologyWithInternalTopic(final
String firstTableName,
return builder.build(config);
}
- @Test
- public void shouldNotRequireParameters() {
+ @ParameterizedTest(name = "{displayName} - {arguments}")
Review comment:
Overriding display name by gradle config may cause trouble when the
display name from test case is well-designed. Another way is that we can create
custom parameterized annotation by junit 5 extension to offer readable display
name by default. However, it seems to me that can be addressed in another PR.
I'm fine to use ```@ParameterizedTest``` as junit reports shows both method
name and argument name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
