ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r556555559
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -890,8 +875,10 @@ public void shouldProcessConsumerRecordList() {
assertThat(record, equalTo(expectedResult));
}
+
Review comment:
Is this intentional?
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -890,8 +875,10 @@ public void shouldProcessConsumerRecordList() {
assertThat(record, equalTo(expectedResult));
}
+
@Test
public void shouldForwardRecordsFromSubtopologyToSubtopology() {
+
Review comment:
Is this intentional?
##########
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##########
@@ -1562,14 +1549,14 @@ public void process(final Record<String, Long> record) {
assertNull(testDriver.getKeyValueStore("storeProcessorStore").get("a"));
testDriver.pipeRecord("input-topic", new TestRecord<>("a", 1L),
new StringSerializer(), new LongSerializer(),
Instant.now());
- Assert.assertEquals(1L,
testDriver.getKeyValueStore("storeProcessorStore").get("a"));
+ assertEquals(1L,
testDriver.getKeyValueStore("storeProcessorStore").get("a"));
}
try (final TopologyTestDriver testDriver = new
TopologyTestDriver(topology, config)) {
assertNull(
- "Closing the prior test driver should have cleaned up this
store and value.",
- testDriver.getKeyValueStore("storeProcessorStore").get("a")
+ testDriver.getKeyValueStore("storeProcessorStore").get("a"),
Review comment:
This can probably go to the previous line now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
