ableegoldman commented on a change in pull request #11272:
URL: https://github.com/apache/kafka/pull/11272#discussion_r704886569
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##########
@@ -67,7 +68,7 @@
stateDirectory,
stateMgr,
inputPartitions,
- config.getLong(StreamsConfig.TASK_TIMEOUT_MS_CONFIG),
Review comment:
Do you mean like a separate `TaskConfig` public class for users to
configure the same way we do for `StreamsConfig`? I've been going back and
forth but ultimately I think we should keep all configs under StreamsConfig so
that all configs for each part of the stack are handled in one place (eg it
would be confusing if within the Consumer client, there were multiple sets of
configs)...still I think we can clean this up eventually, when we do the KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
