On Sun, Oct 16, 2016 at 4:08 PM, 'Terry Brown' via leo-editor

So I'd argue for leaving commit_timestamp.json as is and living with
> the two shortcomings you identified.  But if it's not bearable, we can
> do something like you suggest.

‚ÄčI've already done what I suggested, and it works fine, especially for
official releases. But I see your point: the daily builds won't have
detailed version info.

Most importantly, I want to make things solid for us core developers, and
for those that get Leo using git. Having to install hooks is intolerable in
the long run. The new way is far better.

What to do about daily snapshots? Maybe the script that creates the
snapshot could create commit_timestamp.json. In this case, leoVersion.py
would fall back on the legacy code if git is not around.  It would be
straightforward to do this.

I like this approach--it doesn't let the tail wag the dog. What do you
think? For sure I am not going back to the old way.


You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to