8b6f281 <https://github.com/leo-editor/leo-editor/commit/8b6f281de81662dc20a220061be7ce2531ff90e7> puts the Pypi build and upload notes into nodes. The "Matt's workflow for updating pypi" node can be deleted. I delayed doing so as I'm not sure we're finished with it?
On Sun, Jan 28, 2018 at 9:26 PM, Matt Wilkie <[email protected]> wrote: > Thanks for picking this up and pointing out the bits that aren't clear. > > > Is it really true, as you imply, that pyqt gets installed automatically > with python 3? Or have I misunderstood something? > > Yes that's correct. There is a pypi PyQt wheel for py3.4+ but not for > py2.7+. > > > - I have punted on trying to understand the recipe in detail. Imo, it > should suffice to have people, devs or not, test the *results* of the > recipe (the wheel uploaded to PyPi). Am I missing something or shirking my > duties? > > I'm believe the results of the recipe are solid. The ultimate end goal of > #562 is that the project doesn't rely solely on me for updating new > releases to pypi -- because I'm not all that timely! Though I'm quite happy > to do it when I'm around. > > > Finally, I think work on #562 can proceed in parallel with the release > of Leo 5.2b1. Correct me if I am mistaken. Until the 5.2 final, perhaps it > would be good to label the PyPi release with the short git hash of the rev > on which it is based. > > In my imaginings normally only numbered releases would be uploaded to > pypi, though any interim state is possible. They just need to follow > Semantic Versioning, which means no commit hash. The pypi version is > automatic, handled in `git_version()` - https://github.com/leo-editor/ > leo-editor/blob/master/setup.py#L25 > > > > Imo, almost all of the comments except the first comment could be > deleted or heavily edited. It would be impertinent for me to do so, as you > are the expert, but I would encourage you to shorten the discussion in #562 > as much as possible. > > I'm conflicted on this. I too wish for clean and concise descriptions of > the issue. But the comments are also like an email thread, full of > inconsequential-for-the-current-focus text, but all of which can help > shed light on other issues and ideas when coming from a different starting > point. > > > > - Matt, please separate the upload recipe in leoDist.leo into separate > child/grandchild nodes, > > Will do. Coming up next. > > Matt > > > On Sat, Jan 27, 2018 at 1:30 AM, Edward K. Ream <[email protected]> > wrote: > >> >> >> On Sat, Jan 27, 2018 at 3:20 AM, Edward K. Ream <[email protected]> >> wrote: >> >> >>> >>> I am presently in the midst of a careful revision of this first comment. >>>> This is likely the only way that I can understand all the details myself. >>>> Please review my changes. >>>> >>> >>> I have completed the revision. The highlights: >>> [big snip] >>> >> >> Matt, I just had an idea, which you are free to decline. >> >> Imo, almost all of the comments except the first comment could be deleted >> or heavily edited. It would be impertinent for me to do so, as you are the >> expert, but I would encourage you to shorten the discussion in #562 as much >> as possible. >> >> What do you think? >> >> Btw, I have just "backed up" the first comment in #562 to LeoDocs.leo. >> It's the only thing I care about at present. >> >> Edward >> >> -- >> You received this message because you are subscribed to the Google Groups >> "leo-editor" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at https://groups.google.com/group/leo-editor. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
