On Sun, Jan 28, 2018 at 11:26 PM, Matt Wilkie <map...@gmail.com> wrote:
> Thanks for picking this up and pointing out the bits that aren't clear. > > > Is it really true, as you imply, that pyqt gets installed automatically > with python 3? Or have I misunderstood something? > > Yes that's correct. There is a pypi PyQt wheel for py3.4+ but not for > py2.7+. > Good. > Finally, I think work on #562 can proceed in parallel with the release of > Leo 5.2b1. Correct me if I am mistaken. Until the 5.2 final, perhaps it > would be good to label the PyPi release with the short git hash of the rev > on which it is based. > > In my imaginings normally only numbered releases would be uploaded to > pypi, though any interim state is possible. They just need to follow > Semantic Versioning, which means no commit hash. The pypi version is > automatic, handled in `git_version()` - https://github.com/leo-editor/ > leo-editor/blob/master/setup.py#L25 > Ok then. If I understand correctly, the proper time to upload to PyPi is when Leo 5.7 goes out the door. > Imo, almost all of the comments except the first comment could be deleted > or heavily edited. It would be impertinent for me to do so, as you are the > expert, but I would encourage you to shorten the discussion in #562 as much > as possible. > > I'm conflicted on this. I too wish for clean and concise descriptions of > the issue. But the comments are also like an email thread, full of > inconsequential-for-the-current-focus text, but all of which can help > shed light on other issues and ideas when coming from a different starting > point. > That being so, I suggest first creating an "archive" posting on leo-editor for the entire thread (everything after the first comment). You can reference #562 from the thread, and the archive posting from #562. If something important remains, you can put it in, say, the new second and last comment in #562. What do you think? Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To post to this group, send email to leo-editor@googlegroups.com. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
