On Wed, Mar 28, 2012 at 09:30:44PM +0530, Aneesh Dogra wrote: > > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -60,6 +60,7 @@ include $(SRC_PATH)/tests/fate/vpx.mak > include $(SRC_PATH)/tests/fate/vqf.mak > include $(SRC_PATH)/tests/fate/wavpack.mak > include $(SRC_PATH)/tests/fate/wma.mak > +include $(SRC_PATH)/tests/fate/metadata.mak
This used to be in alphabetical order. You are new here, so this might be news to you, but if in doubt, use alphabetical order and never break existing alphabetical order. > --- /dev/null > +++ b/tests/fate/metadata.mak > @@ -0,0 +1,6 @@ > +FATE_META += fate-metadata-mp3 > +fate-metadata-mp3: CMD = metadata -i $(SAMPLES)/mpegaudio/extra_overread.mp3 > +fate-metadata-mp3: CMP = diff > + > +FATE_TESTS += $(FATE_META) > +fate-meta: $(FATE_META) fate-meta and FATE_META are not good names, add the "data" to make it more descriptive. I don't have an opinion on the rest of the patchset, so please wait for more reviews before rebasing and resending according to my comments. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
