Aneesh Dogra <[email protected]> writes:
> ---
> tests/fate-run.sh | 7 ++++
> tests/metasrc.dat | 82
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 89 insertions(+), 0 deletions(-)
> create mode 100644 tests/metasrc.dat
>
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index b19f0ae..6e7b80c 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> @@ -22,6 +22,7 @@ cmp_shift=${12:-0}
> cmp_target=${13:-0}
> size_tolerance=${14:-0}
>
> +srcmetafile="tests/metasrc.dat"
> outdir="tests/data/fate"
> outfile="${outdir}/${test}"
> errfile="${outdir}/${test}.err"
> @@ -68,6 +69,12 @@ framecrc(){
> avconv "$@" -f framecrc -
> }
>
> +metadata(){
> + cleanfiles=$outdir/`basename $2`;
> + avconv -i "$srcmetafile" "$@" -flags +bitexact -c copy -y "$cleanfiles";
> + avconv -i "$cleanfiles" -f ffmetadata -;
> +}
1. What's with the semicolons?
2. If you need a temporary file, base the name on ${test}, which is
guaranteed to be unique.
3. Do not use $cleanfiles like that. It is a list of files to be
deleted at the end.
4. This will fail on remote targets.
5. What exactly is this supposed to test?
6. Failing to answer #5, what approximately is this supposed to test?
> framemd5(){
> avconv "$@" -f framemd5 -
> }
> diff --git a/tests/metasrc.dat b/tests/metasrc.dat
> new file mode 100644
> index 0000000..6a17f4f
> --- /dev/null
> +++ b/tests/metasrc.dat
> @@ -0,0 +1,82 @@
> +;FFMETADATA1
> +duration=290
> +starttime=0
> +totalduration=290
> +width=640
> +height=480
> +videodatarate=394
> +audiodatarate=125
> +totaldatarate=527
> +framerate=30
> +bytelength=19108485
> +canseekontime=true
> +sourcedata=B4A7D0403HH1310992803941382
> +purl=
> +pmsg=
> +encoder=Lavf52.87.1
WTF is this?
--
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
