Hi, On Wed, Mar 28, 2012 at 9:00 AM, Aneesh Dogra <[email protected]> wrote: > --- > tests/Makefile | 1 + > tests/fate/metadata.mak | 6 ++++++ > tests/ref/fate/metadata-mp3 | 16 ++++++++++++++++ > 3 files changed, 23 insertions(+), 0 deletions(-) > create mode 100644 tests/fate/metadata.mak > create mode 100644 tests/ref/fate/metadata-mp3 [..] > +fate-metadata-mp3: CMD = metadata -i $(SAMPLES)/mpegaudio/extra_overread.mp3
This isn't a good test file. For mp3, you really want a test file that has id3 tags, e.g. things like "title", ideally a cover image. Even better would be to generate such a file using your muxer-demuxer test. You can include data like "title", use the lena image (tests/lena.pnm) as a cover image, and a bunch more, then encode this to mp3 (perhaps at the same time as the actual mp3 encode/decode test), and then demux that file into "metadata" (including something to get the cover image), to ensure that things like the cover image, "title" etc. metadata tags are still there, and correct. Things like "duration" and so on are also useful, but at the moment, I think this test is incomplete. We really want mp3 to test id3 tags also. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
