Aneesh Dogra <[email protected]> writes: > M?ns Rullg?rd <[email protected]> writes: > >>> +metadata(){ >>> + cleanfiles=$outdir/`basename $2`; >>> + avconv -i "$srcmetafile" "$@" -flags +bitexact -c copy -y >>> "$cleanfiles"; >>> + avconv -i "$cleanfiles" -f ffmetadata -; >>> +} > >>1. What's with the semicolons? > Will remove them, sorry! > >>2. If you need a temporary file, base the name on ${test}, which is >>guaranteed to be unique. > Ok! > >>3. Do not use $cleanfiles like that. > Can you please specify in which way you want me to use it? > >> It is a list of files to be deleted at the end. > Yeah that's its been assigned the file which is created for testing > and needs to be removed after the test.
So use it as such, never for anything else. It is a *list* so can absolutely not be used where a single filename is expected. Also, replacing its value is wrong, if you create more files, you should add them to the list. The initial value is currently empty, but there is no promise this will always be the case. >> 4. This will fail on remote targets. > Remote targets? Things accessed over ssh. >> 5. What exactly is this supposed to test? > Its supposed to test our metadata muxers and demuxers. > >> WTF is this? > Yeah the metasrc.dat file is not complete, We need to discuss upon > this, please suggest your proposed changes. That data looks like it was dumped from some random file you happened to have on your hard drive, including information specific to that file that is completely pointless for this test, such as size of the original file. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
