M?ns Rullg?rd <[email protected]> writes:
>> +metadata(){
>> + cleanfiles=$outdir/`basename $2`;
>> + avconv -i "$srcmetafile" "$@" -flags +bitexact -c copy -y "$cleanfiles";
>> + avconv -i "$cleanfiles" -f ffmetadata -;
>> +}
>1. What's with the semicolons?
Will remove them, sorry!
>2. If you need a temporary file, base the name on ${test}, which is guaranteed
>to be unique.
Ok!
>3. Do not use $cleanfiles like that.
Can you please specify in which way you want me to use it?
> It is a list of files to be deleted at the end.
Yeah that's its been assigned the file which is created for testing
and needs to be removed after the test.
> 4. This will fail on remote targets.
Remote targets?
> 5. What exactly is this supposed to test?
Its supposed to test our metadata muxers and demuxers.
> WTF is this?
Yeah the metasrc.dat file is not complete, We need to discuss upon
this, please suggest your proposed changes.
P.S: If you wanted to ask what is metasrc.dat?
A: Actually its the main part of this test, my test works on the
following principle.
Metasrc ---> mux into a file (of the format which needs to be tested ,
example mp3) --> generate an outputfile
outputfile --> demux and read the metadata -> compare with ref file
The ref files are formed in the same way at the point of time when the
demuxer and muxer are assumed to work perfectly.
--
Thanks
Aneesh Dogra (lionaneesh)
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
