On Tue, Aug 10, 2004 at 09:07:52AM -0700, Pete Zaitcev wrote:
> On Tue, 10 Aug 2004 16:24:45 +0200 (CEST)
> Florian Echtler <[EMAIL PROTECTED]> wrote:
>
> > +++ linux/drivers/usb/Makefile 2004-07-30 14:12:48.000000000 +0200
> > +obj-$(CONFIG_USB_PHIDGETSERVO) += misc/
> > obj-$(CONFIG_USB_RIO500) += misc/
> > obj-$(CONFIG_USB_SPEEDTOUCH) += misc/
> > obj-$(CONFIG_USB_TEST) += misc/
> > obj-$(CONFIG_USB_TIGL) += misc/
> > obj-$(CONFIG_USB_USS720) += misc/
> > -obj-$(CONFIG_USB_PHIDGETSERVO) += misc/
>
> What is this supposed to mean?
He's just putting them in sorted order, I asked for that a few revs ago.
<snipped some good comments>
> > + // let the user know what node this device is now attached to
> > + info("%s connected to USB minor %d", DRIVER_DESC, dev->minor);
>
> This is not well thought out. Firstly, dmesg can scroll away.
> The /var/log/messages might not be readable, or missing.
> It's not a show-stopper, but something you might wish to change.
> How about adding an identification ioctl?
Ick no! You can get the info directly from sysfs. No ioctl is needed.
I don't mind the info() call, as it's quite useful when getting dumps
from users who are having problems.
But you should use the dev_info() macro instead of just info(). It
gives you some real information, not just this fluffy "I grabed minor
number X" message.
thanks,
greg k-h
-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
