On Tue, 1 Apr 2003, Charlie Brady wrote: >On Tue, 1 Apr 2003, Andreas Aardal Hanssen wrote: >> On Mon, 31 Mar 2003, Charlie Brady wrote: >> I think your patch may be seriously broken, and there was a good reason >> why the code was commented out. >As I say, the users were much happier.
A user is generally happy until the day that he is Saddam and sent a white flag by email and Georgie used an Maildir IMAP server that caused that message to disappear. ;) >> Saving to tmp, then linking to new/ with time(NULL) is a Maildir >> requirement, not an option, and Dovecot and Courier-IMAP and Binc IMAP are >> not doing it wrong. >The race condition you referred to on the dovecot mailing list concerned >delivery of new messages at the same time that a client (e.g. imap server) >was moving messages from new/ to cur/. This isn't the situation with old >messages which you intend to move around. Their basenames have already >been disambiguated at delivery time, at least for the common simple case >of a single inbox per user, and in the case of multiple inboxes and an OS >which doesn't recycle PIDs within one second. The condition I raised was that, yes. But here is the essential point: Any message that is to end up in cur/ in Maildir must first have lived in new/. Any message placed in new/ must have a base part whose first section is the result of time(NULL) or the seconds of gettimeofday. >OTOH, if you do not satisfy the RFC2060 recommendations wrt internaldate, >then you will have unhappy users. Maildir was not designed with IMAP in mind. Rumors have it that Dan is defining a new mailbox format for qmail 2 (haha ;) ) that will be better for other protocols than POP3. >Perhaps there is another way that internaldate can be preserved when >messages are copied or appended. Could we not adjust ctime or mtime and >use that? That would be interesting. The time section of the file as it is stored in Maildir could be ignored, and we could only look at the ctime. Would we have to make assumptions on what other Maildir clients are accessing the depot concurrently? Andy -- Andreas Aardal Hanssen | http://www.andreas.hanssen.name/gpg Author of Binc IMAP | Nil desperandum
