Github user JJoe2 commented on the issue:
    I don’t have access to svn, so I’ll start by tidying up my fork in 
github this weekend.
    I understand your point that adding methods to a public interface is a 
breaking change.  Though it’s also true that it’s unlikely that third 
parties are developing custom implementations of that particular interface.
    I agree it’s better to check for IFlushable and will modify accordingly.
    From: Stefan Bodewig []
    Sent: 13 October 2016 07:58
    To: apache/log4net
    Cc: JJoe2; Author
    Subject: Re: [apache/log4net] API to flush appenders that buffer logging 
data (#25)
    I've ensured all line-ends are consistent and set to native in svn trunk - 
git is not our primary repository, is. If you've got 
access to svn maybe it is a better idea to develop your patch against it and 
attach it to JIRA. Using the traditional way :-)
    I'd really prefer we don't add any new methods to existing interfaces as 
this may break custom implementations. That's why I didn't want Flush in 
ILoggerRepository. We can't know who has implemented the interface in library 
or application code. LoggerManager could check whether ILoggerRepository 
implemented IFlushable and simply don't do anything in its Flush implementation 
if it didn't.
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on 
GitHub<>, or 
mute the 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to