Github user JJoe2 commented on the issue:
https://github.com/apache/log4net/pull/25
I donât have access to svn, so Iâll start by tidying up my fork in
github this weekend.
I understand your point that adding methods to a public interface is a
breaking change. Though itâs also true that itâs unlikely that third
parties are developing custom implementations of that particular interface.
I agree itâs better to check for IFlushable and will modify accordingly.
From: Stefan Bodewig [mailto:notificati...@github.com]
Sent: 13 October 2016 07:58
To: apache/log4net
Cc: JJoe2; Author
Subject: Re: [apache/log4net] API to flush appenders that buffer logging
data (#25)
I've ensured all line-ends are consistent and set to native in svn trunk -
git is not our primary repository,
https://svn.apache.org/repos/asf/logging/log4net/trunk/ is. If you've got
access to svn maybe it is a better idea to develop your patch against it and
attach it to JIRA. Using the traditional way :-)
I'd really prefer we don't add any new methods to existing interfaces as
this may break custom implementations. That's why I didn't want Flush in
ILoggerRepository. We can't know who has implemented the interface in library
or application code. LoggerManager could check whether ILoggerRepository
implemented IFlushable and simply don't do anything in its Flush implementation
if it didn't.
â
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/log4net/pull/25#issuecomment-253421362>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AFY0u5EBnT3LnqX0W-949j7U-fd4djBEks5qzchugaJpZM4IOSN6>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
