Github user bodewig commented on the issue:
    @JJoe2 I'm sorry, but now the patch contains all the changes we've made 
since you started your branch. It would be good if you could rebase your branch.
    Many thanks for the `w=1` trick, I wasn't aware of it. I do care about 
line-feeds but I care about identifying what has changed more :-) - in svn the 
linefeeds are correct, BTW.
    I'd really prefer to keep the Flush and UTC changes separate. That one 
changes binary serialization of `LoggingEvent`s which means people can't use 
different versions of log4net and the remoting sink, for example. Something 
we'd need to document and warn against, if we deem it acceptable.
    Actually I would have preferred a separate PR for 57299a4 as well as it is 
a different JIRA issue. I've applied that separately now (and also locked 
`m_ht` in `Clear`) so it should disappear if you rebase your branch.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to