[
https://issues.apache.org/jira/browse/MAPREDUCE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295082#comment-14295082
]
Junping Du commented on MAPREDUCE-6225:
---------------------------------------
Thanks [~varun_saxena] for delivering a patch!
Mostly looks fine, but only a trivial thing here:
In JobSubmitter.java, we have similar logic in copyAndConfigureFiles() and
addLog4jToDistributedCache() with setting job's working directory in case not
set before. I think we should at least omit one because it get duplicated in
its call flow.
{code}
+ job.getWorkingDirectory();
{code}
Other looks good to me.
> Fix new findbug warnings in hadoop-mapreduce-client-core
> --------------------------------------------------------
>
> Key: MAPREDUCE-6225
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6225
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Attachments: MAPREDUCE-6225.001.patch
>
>
> Recent precommit builds in hadoop-mapreduce-client-core are flagging findbug
> warnings that appear to be new with the recent findbugs upgrade. These need
> to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
