[
https://issues.apache.org/jira/browse/MAPREDUCE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321796#comment-14321796
]
Tsuyoshi OZAWA commented on MAPREDUCE-6225:
-------------------------------------------
[~varun_saxena] [~ajisakaa] [~djp] thank you for taking this JIRA.
{code}
+ // Get the working directory. If not set, sets it to filesystem working dir
+ job.getWorkingDirectory();
{code}
I prefer to use job.setWorkingDirectory(jtFs.getWorkingDirectory()) for
readability - it's a bit tricky and confusing for readers.
Also I'd like to +1 for moving
job.setWorkingDirectory(jtFs.getWorkingDirectory()) to before
copyAndConfigureFiles(job, jobSubmitDir, replication) at first to call one time
as Junping mentioned.
> Fix new findbug warnings in hadoop-mapreduce-client-core
> --------------------------------------------------------
>
> Key: MAPREDUCE-6225
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6225
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Attachments: MAPREDUCE-6225.001.patch, MAPREDUCE-6225.002.patch
>
>
> Recent precommit builds in hadoop-mapreduce-client-core are flagging findbug
> warnings that appear to be new with the recent findbugs upgrade. These need
> to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
