[
https://issues.apache.org/jira/browse/MAPREDUCE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321072#comment-14321072
]
Akira AJISAKA commented on MAPREDUCE-6225:
------------------------------------------
bq. I did not see any need to call getWorkingDirectory.
{{JobContext.WORKING_DIR}} is not being set anywhere in these 2 places(in the
call flow) for there to be a need to reset again. So I am not sure why this
code even exists in the first place.
Make sense to me. In addition, {{JobContext.WORKING_DIR}} is not being
referenced anywhere between these 2 places. +1 for removing
{{job.getWorkingDirectory()}} in {{addLog4jToDistributedCache()}}. What do you
think, [~djp]?
> Fix new findbug warnings in hadoop-mapreduce-client-core
> --------------------------------------------------------
>
> Key: MAPREDUCE-6225
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6225
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Attachments: MAPREDUCE-6225.001.patch, MAPREDUCE-6225.002.patch
>
>
> Recent precommit builds in hadoop-mapreduce-client-core are flagging findbug
> warnings that appear to be new with the recent findbugs upgrade. These need
> to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
