[
https://issues.apache.org/jira/browse/MAPREDUCE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302687#comment-14302687
]
Junping Du commented on MAPREDUCE-6225:
---------------------------------------
Hi [~varun_saxena], sorry for missing this.
For following code, I think job.getWorkingDirectory() in
addLog4jToDistributedCache() get called first. Would you double check it?
Thanks!
{code}
@@ -390,10 +390,8 @@ private void copyAndConfigureFiles(Job job, Path
jobSubmitDir)
short replication = (short)conf.getInt(Job.SUBMIT_REPLICATION, 10);
copyAndConfigureFiles(job, jobSubmitDir, replication);
- // Set the working directory
- if (job.getWorkingDirectory() == null) {
- job.setWorkingDirectory(jtFs.getWorkingDirectory());
- }
+ // Get the working directory. If not set, sets it to filesystem working dir
+ job.getWorkingDirectory();
}
/**
@@ -773,11 +771,6 @@ private void addLog4jToDistributedCache(Job job,
if (!log4jPropertyFile.isEmpty()) {
short replication = (short)conf.getInt(Job.SUBMIT_REPLICATION, 10);
copyLog4jPropertyFile(job, jobSubmitDir, replication);
-
- // Set the working directory
- if (job.getWorkingDirectory() == null) {
- job.setWorkingDirectory(jtFs.getWorkingDirectory());
- }
}
}
}
{code}
> Fix new findbug warnings in hadoop-mapreduce-client-core
> --------------------------------------------------------
>
> Key: MAPREDUCE-6225
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6225
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Attachments: MAPREDUCE-6225.001.patch, MAPREDUCE-6225.002.patch
>
>
> Recent precommit builds in hadoop-mapreduce-client-core are flagging findbug
> warnings that appear to be new with the recent findbugs upgrade. These need
> to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
