[ 
https://issues.apache.org/jira/browse/MAPREDUCE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310869#comment-14310869
 ] 

Varun Saxena commented on MAPREDUCE-6225:
-----------------------------------------

[~djp], I did not call getWorkingDirectory in addLog4jToDistributedCache 
because it was inside a condition.
I had tested this as well. I did not see any need to call getWorkingDirectory. 
{{JobContext.WORKING_DIR}} is not being set anywhere in these 2 places(in the 
call flow) for there to be a need to reset again.
So I am not sure why this code even exists in the first place.
I hope I didn't miss anything.



> Fix new findbug warnings in hadoop-mapreduce-client-core
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-6225
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6225
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: MAPREDUCE-6225.001.patch, MAPREDUCE-6225.002.patch
>
>
> Recent precommit builds in hadoop-mapreduce-client-core are flagging findbug 
> warnings that appear to be new with the recent findbugs upgrade.  These need 
> to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to