On Tue, Dec 11, 2007 at 08:39:21PM +0100, Jehan wrote:

> Of course to be more portable, the better would be to do a
> #ifdef HAVE_NL_LANGINFO
> // code with nl_langinfo (CODESET)
> #else
> // current code
> #endif

As I've said before, I don't know anything about encodings: But my
suggestion would be NOT to do the above ifdef.

If the current code is wrong, it should be replaced. The above #ifdef
means maintaining two code branches, one of which is flawed. Plus on my
system, it looks like langinfo.h is provided by glibc.

> If this is OK for you, I propose to commit this on svn (already modified
> locally on my computer).

Incidentally, I did not get any commit notification from your latest
commit. Perhaps the SF notify hook is broken. I'll look into it,

GI

-- 
'Fairy tales' -- Horror stories for children to get them used to
reality.

-------------------------------------------------------------------------
SF.Net email is sponsored by: 
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Materm-devel mailing list
Materm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/materm-devel
mrxvt home page: http://materm.sourceforge.net

Reply via email to